persist: Allow appending Datum::Null to Codec Row data #29234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParkMyCar
commented
Aug 26, 2024
| @@ -639,6 +649,10 @@ impl PersistClient { | |||
| T: Timestamp + Lattice + Codec64, | |||
| D: Semigroup + Codec64 + Send + Sync, | |||
| { | |||
| if !DANGEROUS_ENABLE_SCHEMA_EVOLUTION.get(&self.cfg.configs) { | |||
| panic!("tried to evolve the schema of a Persist shard without the feature enabled"); | |||
There was a problem hiding this comment.
We could return an error here instead of panicking, but because this should never get called in Prod I figured panicking was better. Happy to change though!
danhhz
approved these changes
Aug 27, 2024
src/persist-client/src/lib.rs
Outdated
| "persist_dangerous_enable_schema_evolution", | ||
| false, | ||
| "\ | ||
| DANGEROUS DO NOT ENABLE IN PRODUCTION ENVIRONMENTS! |
| @@ -639,6 +649,10 @@ impl PersistClient { | |||
| T: Timestamp + Lattice + Codec64, | |||
| D: Semigroup + Codec64 + Send + Sync, | |||
| { | |||
| if !DANGEROUS_ENABLE_SCHEMA_EVOLUTION.get(&self.cfg.configs) { | |||
| panic!("tried to evolve the schema of a Persist shard without the feature enabled"); | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
Datum::Nullonto Codec Row data when columns are missingcompare_and_evolve_schema, behind a scary dyncfg.We should never enable this dyncfg in staging or prod until compaction can handle data that is written in different schemas, but I'm putting it up because it helps me test
ALTER TABLEend-to-end. @danhhz and I chatted about this hereMotivation
Small progress towards
ALTER TABLEChecklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.