mzbuild: Don't try to build on non-builder CI machines #29681
Merged
+36
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
def-
commented
Sep 20, 2024
misc/python/materialize/mzbuild.py
Outdated
| assert max_retries > 0 | ||
|
|
||
| deps_to_build = [dep for dep in self if not dep.try_pull(max_retries)] | ||
| deps_to_build = [ | ||
| dep for dep in self if not dep.publish or dep.try_pull(max_retries) |
There was a problem hiding this comment.
No need to try to pull an image that we never publish, becomes slower with this PR
def-
commented
Sep 20, 2024
| print( | ||
| f"+++ Expected builds to be available, the build probably failed, so not proceeding: {expected_deps}" | ||
| ) | ||
| sys.exit(5) |
There was a problem hiding this comment.
Unique return code, so far not used, but in the future we could do auto-retries in mkpipeline.py based on it.
nrainer-materialize
approved these changes
Sep 20, 2024
def-
force-pushed
the
pr-build-ci
branch
2 times, most recently
from
e929e60
to
6c05954
Compare
They won't succeed anyway, better to fail the test than time out while uselessly building. Seen in https://buildkite.com/materialize/test/builds/90870 Also retry longer (~1 minute) and not just with a 1s sleep inbetween
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They won't succeed anyway, better to fail the test than time out while uselessly building. Seen in https://buildkite.com/materialize/test/builds/90870
Also retry longer (~1 minute) and not just with a 1s sleep inbetween
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.