Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: Print durations by default and sort them #29682

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

def-
Copy link
Contributor

@def- def- commented Sep 20, 2024

By sorting them it's very easy to see which lint actually contributed to the huge runtime, both locally and in CI. --no-print-duration can be specified if you really don't want it. Example output:

1 check in ci/test/lint-main/before
✓ [ 0.01s] can-lint.sh
16 checks in ci/test/lint-main/checks
✓ [ 0.01s] check-rust-version.sh
✓ [ 0.10s] check-python-discouraged.sh
✓ [ 0.20s] check-test-history-versioning.sh
✓ [ 0.61s] check-mzcompose-files.sh
✓ [ 1.49s] check-generation.sh
✓ [ 3.81s] check-python-docs.sh
✓ [ 3.84s] check-python-formatting.sh
✓ [ 4.52s] check-shell-files.sh
✓ [ 5.24s] check-rust-test-attributes.sh
✓ [ 8.16s] check-bazel.sh
✓ [ 8.70s] check-cargo.sh
✓ [ 9.97s] check-new-line.sh
✓ [10.00s] check-copyright.sh
✓ [13.09s] check-protobuf.sh
✓ [14.96s] check-python-files.sh
✓ [150.44s] check-crate-license-listing.sh
1 check in ci/test/lint-main/after
✓ [ 0.02s] check-no-diff.sh
✓ All checks successful

check-crate-license-listing.sh is often slow for me, I'll try disabling it locally. Maybe related to https://github.com/clearlydefined/service/issues/749

2024-09-20 11:38:24.300092832 +00:00:00 [WARN] failed to request license information from clearly defined: error sending request for url (https://api.clearlydefined.io/definitions): operation timed out
2024-09-20 11:38:24.300124862 +00:00:00 [WARN] failed to request license information from clearly defined: error sending request for url (https://api.clearlydefined.io/definitions): operation timed out
2024-09-20 11:38:24.300165939 +00:00:00 [WARN] failed to request license information from clearly defined: error sending request for url (https://api.clearlydefined.io/definitions): operation timed out
2024-09-20 11:38:24.30018817 +00:00:00 [WARN] failed to request license information from clearly defined: error sending request for url (https://api.clearlydefined.io/definitions): operation timed out
2024-09-20 11:38:24.300221563 +00:00:00 [WARN] failed to request license information from clearly defined: error sending request for url (https://api.clearlydefined.io/definitions): operation timed out
2024-09-20 11:38:24.300778152 +00:00:00 [WARN] failed to request license information from clearly defined: error sending request for url (https://api.clearlydefined.io/definitions): operation timed out
2024-09-20 11:38:24.300290021 +00:00:00 [WARN] failed to request license information from clearly defined: error sending request for url (https://api.clearlydefined.io/definitions): operation timed out
2024-09-20 11:38:24.300297885 +00:00:00 [WARN] failed to request license information from clearly defined: error sending request for url (https://api.clearlydefined.io/definitions): operation timed out
2024-09-20 11:38:24.300379518 +00:00:00 [WARN] failed to request license information from clearly defined: error sending request for url (https://api.clearlydefined.io/definitions): operation timed out
2024-09-20 11:38:24.300388094 +00:00:00 [WARN] failed to request license information from clearly defined: error sending request for url (https://api.clearlydefined.io/definitions): operation timed out
2024-09-20 11:38:24.30126991 +00:00:00 [WARN] failed to request license information from clearly defined: error sending request for url (https://api.clearlydefined.io/definitions): operation timed out
2024-09-20 11:38:24.300235328 +00:00:00 [WARN] failed to request license information from clearly defined: error sending request for url (https://api.clearlydefined.io/definitions): operation timed out
2024-09-20 11:38:24.30088404 +00:00:00 [WARN] failed to request license information from clearly defined: error sending request for url (https://api.clearlydefined.io/definitions): operation timed out
2024-09-20 11:38:24.300459798 +00:00:00 [WARN] failed to request license information from clearly defined: error sending request for url (https://api.clearlydefined.io/definitions): operation timed out
2024-09-20 11:38:24.309217001 +00:00:00 [WARN] failed to request license information from clearly defined: error sending request for url (https://api.clearlydefined.io/definitions): operation timed out
2024-09-20 11:38:49.150011783 +00:00:00 [WARN] crate 'jsonpath-rust 0.5.1' doesn't have a license field
2024-09-20 11:38:54.301643775 +00:00:00 [WARN] failed to request license information from clearly defined: error sending request for url (https://api.clearlydefined.io/definitions): operation timed out
2024-09-20 11:39:14.12170684 +00:00:00 [WARN] failed to request license information from clearly defined: error sending request for url (https://api.clearlydefined.io/definitions): operation timed out
2024-09-20 11:39:14.941230381 +00:00:00 [WARN] failed to request license information from clearly defined: error sending request for url (https://api.clearlydefined.io/definitions): operation timed out
2024-09-20 11:39:44.121885999 +00:00:00 [WARN] failed to request license information from clearly defined: error sending request for url (https://api.clearlydefined.io/definitions): operation timed out
2024-09-20 11:39:46.383852837 +00:00:00 [WARN] failed to request license information from clearly defined: error sending request for url (https://api.clearlydefined.io/definitions): operation timed out
2024-09-20 11:39:46.43471935 +00:00:00 [WARN] failed to request license information from clearly defined: error sending request for url (https://api.clearlydefined.io/definitions): operation timed out

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

By sorting them it's very easy to see which lint actually contributed to
the huge runtime
@nrainer-materialize
Copy link
Contributor

check-crate-license-listing.sh is often slow for me, I'll try disabling it locally

Yeah, let's allow disabling that through an env var

@def-
Copy link
Contributor Author

def- commented Sep 20, 2024

If it's just a me-problem maybe not worth it.

@def- def- requested a review from a team as a code owner September 20, 2024 11:54
@def- def- enabled auto-merge September 20, 2024 11:55
@def- def- merged commit fbb6104 into MaterializeInc:main Sep 20, 2024
87 checks passed
@def- def- deleted the pr-durations branch September 20, 2024 22:37
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants