Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make cluster sizes configurable in the orchestratord helm chart #30370

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

doy-materialize
Copy link
Contributor

Motivation

customers will need to do this, and the defaults we were choosing before don't work with the test suite

currently a draft because it's not quite working yet

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@doy-materialize doy-materialize marked this pull request as ready for review November 7, 2024 17:00
@doy-materialize
Copy link
Contributor Author

okay, this works after picking names that aren't mz_probe or *cc because those are currently hardcoded to use disk (we should change this, but that will be more effort to fix)

Copy link
Contributor

@bobbyiliev bobbyiliev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@doy-materialize doy-materialize merged commit 9b6ef61 into main Nov 7, 2024
14 checks passed
@doy-materialize doy-materialize deleted the doy-cluster-sizes branch November 7, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants