Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: remove use of fast_float crate because RUSTSEC-2024-0379 #30426

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

ParkMyCar
Copy link
Member

As it says in the title, removes our one use of the fast_float crate because of RUSTSEC-2024-0379

Motivation

  • This PR fixes a previously unreported bug.

RUSTSEC-2024-0379

Tips for reviewer

There's a chance fast_float could have slightly different float parsing than std, will kick of a round of Nightlies to see

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@ParkMyCar ParkMyCar requested review from def- and jkosh44 November 11, 2024 18:50
@ParkMyCar ParkMyCar requested a review from a team as a code owner November 11, 2024 18:50
@ParkMyCar ParkMyCar mentioned this pull request Nov 11, 2024
5 tasks
@ParkMyCar
Copy link
Member Author

Kicked off a round of Nightlies: https://buildkite.com/materialize/nightly/builds/10347

Copy link
Contributor

@def- def- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ParkMyCar
Copy link
Member Author

For posterity, it seems like core and std should be using the same algorithm as fast_float so we don't expect performance regressions here. See rust-lang/rust#86761

@ParkMyCar ParkMyCar enabled auto-merge (squash) November 11, 2024 19:19
@ParkMyCar ParkMyCar disabled auto-merge November 11, 2024 19:19
@ParkMyCar ParkMyCar force-pushed the deps/remove-fast-float branch from bcbe171 to 07f2c6a Compare November 11, 2024 19:20
@ParkMyCar ParkMyCar enabled auto-merge (squash) November 11, 2024 19:20
@ParkMyCar ParkMyCar merged commit ad9a093 into MaterializeInc:main Nov 11, 2024
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants