Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0dt source rehydration testing: Postgres, MySQL, Kafka #30514

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

0dt source rehydration testing: Postgres, MySQL, Kafka #30514

wants to merge 2 commits into from
+352 −14

Conversation

def-
Copy link
Contributor

@def- def- commented Nov 15, 2024

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@def- def- force-pushed the pr-0dt-source2 branch 3 times, most recently from fc695b9 to 761f436 Compare November 18, 2024 11:23
@def- def- changed the title ci: Try enabling enable_0dt_deployment_sources in new versions 0dt source testing Nov 18, 2024
@def- def- force-pushed the pr-0dt-source2 branch 6 times, most recently from 93b4716 to f17acea Compare November 21, 2024 22:52
@def- def- marked this pull request as ready for review November 21, 2024 22:52
@def- def- requested a review from a team as a code owner November 22, 2024 06:40
@def- def- requested a review from aljoscha November 22, 2024 06:43
@def- def- requested review from benesch and jkosh44 November 22, 2024 09:54
def-
def- commented Nov 22, 2024
View reviewed changes
ci/nightly/pipeline.template.yml
@@ -1663,6 +1663,16 @@ steps:
- ./ci/plugins/mzcompose:
composition: backup-restore-postgres

- id: 0dt
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rehydration tests with real large data are quite slow, 90 min total for the test currently. I find them important enough to still do, but moved the test to nightly for now

@def- def- changed the title 0dt source testing 0dt source testing: Postgres, MySQL, Kafka Nov 22, 2024
@def- def- changed the title 0dt source testing: Postgres, MySQL, Kafka 0dt source rehydration testing: Postgres, MySQL, Kafka Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aljoscha aljoscha Awaiting requested review from aljoscha

@benesch benesch Awaiting requested review from benesch

@jkosh44 jkosh44 Awaiting requested review from jkosh44

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@def-