Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terraform + helm-chart e2e test #30556

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Terraform + helm-chart e2e test #30556

wants to merge 1 commit into from
+739 −43

Conversation

def-
Copy link
Contributor

@def- def- commented Nov 19, 2024

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@def- def- force-pushed the pr-terraform branch 2 times, most recently from d60af7f to aa94d8a Compare November 19, 2024 14:22
bobbyiliev
bobbyiliev reviewed Nov 19, 2024
View reviewed changes
test/terraform/main.tf Outdated Show resolved Hide resolved
@def- def- force-pushed the pr-terraform branch 12 times, most recently from 80015e6 to 3ef256f Compare November 21, 2024 22:27
@def- def- changed the title WIP: Terraform test Terraform + helm-chart e2e test Nov 21, 2024
@def- def- marked this pull request as ready for review November 21, 2024 22:32
@def- def- requested a review from a team as a code owner November 21, 2024 22:32
@def- def- requested a review from bobbyiliev November 21, 2024 22:32
@def- def- force-pushed the pr-terraform branch 6 times, most recently from 9aacaf7 to 9ccd0db Compare November 22, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbyiliev bobbyiliev Awaiting requested review from bobbyiliev

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@def- @bobbyiliev