Instance config with stricter offset is compatible #30585
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce InstanceConfig::compatible_with to check if two configurations
are compatible. Two configurations are considered compatible iff the
logging configuration is equal and the expiration offset of the other
configuration is stricter than or equal to the current one.
Addresses a concern with replica expiration that didn't allow us to
strengthen the value without risking replica restarts in case of envd
restarts. This doesn't solve the problem of relaxing the expiration, which
would still cause replica restarts -- there doesn't seem to be a good
alternative because the replicas aren't actually compatible.
Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.