Skip to content

persist: provide a way to disable the isolated runtime #34148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2025
Merged

persist: provide a way to disable the isolated runtime #34148

merged 1 commit into from
Nov 20, 2025
+51 −8

Conversation

@teskje
Copy link
Contributor

@teskje teskje commented Nov 15, 2025 •
edited
Loading

This PR introduces PersistClientCache::new_for_turmoil, as a way to use persist in turmoil tests. In particular, this disables the isolated runtime. Tasks that would be spawned there are instead spawned in the current runtime. The method is gated behind a new "turmoil" feature.

Motivation

  • This PR adds a test feature that has not yet been specified.

Make it possible to configure persist in a way compatible with turmoil.

Tips for reviewer

Usage example in #34110.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@teskje
persist: provide a way to disable the isolated runtime
a5d2cc6 
This commit introduces `PersistClientCache::new_for_turmoil`, as a way
to use persist in turmoil tests. In particular, this disables the
isolated runtime. Tasks that would be spawned there are instead spawned
in the current runtime. The method is gated behind a new "turmoil"
feature.
@teskje teskje marked this pull request as ready for review November 16, 2025 12:57
@teskje teskje requested a review from a team as a code owner November 16, 2025 12:57
@teskje teskje requested a review from bkirwi November 16, 2025 12:58
@teskje teskje mentioned this pull request Nov 16, 2025
Merged
5 tasks
bkirwi
bkirwi approved these changes Nov 19, 2025
View reviewed changes
Copy link
Contributor

@bkirwi bkirwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable, thanks!

@teskje
Copy link
Contributor Author

teskje commented Nov 20, 2025

TFTR!

@teskje teskje merged commit b6ee316 into MaterializeInc:main Nov 20, 2025
129 checks passed
@teskje teskje deleted the persist-turmoil-runtime branch November 20, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkirwi bkirwi bkirwi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@teskje @bkirwi