Skip to content

Conversation

@petrosagg
Copy link
Contributor

...and a syntax fix

Motivation

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

...and a syntax fix

Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
@petrosagg petrosagg requested a review from a team as a code owner November 17, 2025 16:08
source as change events stream in, as a result of `INSERT`, `UPDATE` and
`DELETE` operations in the upstream MySQL database.
It's important to note that the schema metadata is captured when the source is
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So ... MySQL and SQL Server .... they are the old syntax for now, yes? Or is it that these statements were obsolete, even with the old syntax.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly, they are obsolete in general

Copy link
Contributor

@martykulma martykulma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @petrosagg!

@petrosagg pointed out that the partition by syntax is valid, but there really isn't any user visible impact to setting it. This PR removes mention from the SQL example, but in the rendered page, PARTITION BY is still listed under WITH <with_options>, it just doesn't have any description because this syntax doesn't do anything.

My vote would be to remove the the syntax from the docs if it doesn't do anything, but leaving it in doesn't hurt anything.

Copy link
Contributor

@kay-kim kay-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree w. removing from options as well. I'll just merge this and update to minimize the moving parts.

@kay-kim kay-kim merged commit a66f4df into MaterializeInc:docs-upcoming-v26.0.0 Nov 17, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants