Skip to content

Conversation

@def-
Copy link
Contributor

@def- def- commented Nov 18, 2025

To get rid of the number_prefix dependency.

Noticed in https://buildkite.com/materialize/nightly/builds/14113#019a97f0-2f1a-48ac-8a72-11b26a6d913d

See https://rustsec.org/advisories/RUSTSEC-2025-0119

I'm not happy with the new deny.toml entries CC @doy-materialize
If anyone wants to fix it up or has a better idea, I'm all ears!

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@def- def- requested review from a team as code owners November 18, 2025 17:23
@def-
Copy link
Contributor Author

def- commented Nov 19, 2025

Ready for review!

Copy link
Contributor

@teskje teskje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems unnecessary to depend on all these windows crates if we don't support windows targets. Some of these dependencies are target-gated (e.g.) but I guess there is no way to explain that to cargo deny?

@def-
Copy link
Contributor Author

def- commented Nov 20, 2025

I'm not sure!

@def- def- merged commit e598639 into MaterializeInc:main Nov 20, 2025
129 checks passed
@def- def- deleted the pr-indicatif-bump branch November 20, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants