Skip to content

Conversation

@SangJunBak
Copy link
Contributor

Even though redacted, we still leak some of the values via annotations.

Motivation

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@SangJunBak SangJunBak requested a review from jubrad November 19, 2025 20:19
@SangJunBak SangJunBak marked this pull request as ready for review November 19, 2025 21:22
@SangJunBak SangJunBak requested a review from a team as a code owner November 19, 2025 21:22
@SangJunBak SangJunBak force-pushed the jun/remove-secrets-from-mz-debug branch from 6e38776 to 3b822d7 Compare November 19, 2025 21:31
Even though redacted, we still leak some of the values via annotations.
@SangJunBak SangJunBak force-pushed the jun/remove-secrets-from-mz-debug branch from 3b822d7 to eabee39 Compare November 19, 2025 21:49
@SangJunBak SangJunBak merged commit 265f7af into MaterializeInc:main Nov 19, 2025
133 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants