[wip] replacement materialized views #34234
Draft
+831
−312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the storage controller's data structures to support specifying a "view" storage collection, i.e., a storage collection that points to the same persist shard as another, for other data sources than `Table`. The intent is specifically to get support for `DataSource::Other`, in preparation for `ALTER MATERIALIZED VIEW`. Rather than adding a `primary` field to the `DataSource::Other` variant, this commit instead moves the `primary` field out of `DataSource::Table` and into `CollectionDescription`. This reflects the fact that the "primary" concept is independent of the data source, even though it's currently only used for tables. It also removes some visual clutter.
teskje
force-pushed
the
replacement-mvs
branch
2 times, most recently
from
6fb0f85 to
eba1d14
Compare
When applying an item `StateUpdate`, we had an optimization that would skip parsing the `create_sql` if it hadn't change, and reuse the old `CatalogEntry` instead. This produces the wrong outcome if the `extra_versions` change without the SQL changing: Any version updates are not reflected in the new `CatalogEntry`. To fix this, this commit removes the optimization, under the assumption that DDL is sufficiently rare that we can live without it. If that turns out not the be the case, we can keep the optimization and refine the conditions under which SQL parsing is performed, though that seems brittle.
teskje
force-pushed
the
replacement-mvs
branch
from
eba1d14 to
dcf7cdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.