Update to v27.2 of the protobuf library, checked out at build time #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… source. The appropriate revision of the protobuf source code, and its abseil-cpp dependency, are fetched from their git repositories, instead of vendoring the corresponding source code.
|
|
|
Thanks for the PR here, @emarsden! Going to move forward with #21, details here: #20 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates to the latest version of the protobuf source code. Instead of vendoring the (voluminous) source code, it is checked out from the GitHub repository at build time. The checkout uses the git2-rs library (binding to libgit2 which is built from source), so does not introduce a dependency on the git binary.
Fixes the build failure reported at #20.