Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle unset optional properties #17

Closed
rartino opened this issue Jun 14, 2018 · 1 comment · Fixed by #69
Closed

Handle unset optional properties #17

rartino opened this issue Jun 14, 2018 · 1 comment · Fixed by #69
Assignees
@ctoher
Labels
event/workshop-2018 Issues discussed during OPTIMaDe workshop 2018 priority/mid There is a consensus that this have average priority to sort out. status/approved Consensus has been reached to implement this as described in the top comment. status/has-concrete-suggestion This issue has one or more concrete suggestions spelled out that can be brought up for consensus. topic/filtering-language Issue discussing changes and improvements to the query and filtering language topic/response-format Issue discussing changes and improvements to the API response format
Milestone
1.0 release

Comments

@rartino
Copy link
Contributor

rartino commented Jun 14, 2018

We should adopt policies around unset optional properties.
@rartino rartino added the event/workshop-2018 Issues discussed during OPTIMaDe workshop 2018 label Jun 14, 2018
@rartino
Copy link
Contributor Author

rartino commented Jun 14, 2018 •
edited
Loading

Suggestion:

Comparisons involving the value of an unset property always evaluate to false. Unset properties are excluded from output unless explicitly requested. In the latter case they are represented in json as the property having null as value. One can query on unset properties using:

     property IS KNOWN            means: property is present and has a definite value

Specifically, it is considered that a property that 'is null' in e.g., a backend or json does not have a definite value.

@rartino rartino added status/has-concrete-suggestion This issue has one or more concrete suggestions spelled out that can be brought up for consensus. topic/filtering-language Issue discussing changes and improvements to the query and filtering language topic/response-format Issue discussing changes and improvements to the API response format status/approved Consensus has been reached to implement this as described in the top comment. priority/mid There is a consensus that this have average priority to sort out. labels Jun 14, 2018
@ltalirz ltalirz added this to the 1.0 release milestone Jun 15, 2018
@ctoher ctoher mentioned this issue Jul 12, 2018
Merged
@rartino rartino mentioned this issue Nov 22, 2018
Closed
rartino added a commit to rartino/OPTIMADE that referenced this issue May 12, 2019
@rartino
Filter changes related to Materials-Consortia#58, Materials-Consortia#17
2b048c8 
, Materials-Consortia#42, Materials-Consortia#19, Materials-Consortia#16, Materials-Consortia#47
@rartino rartino mentioned this issue May 13, 2019
Merged
@giovannipizzi giovannipizzi mentioned this issue Jun 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ctoher ctoher

Labels
event/workshop-2018 Issues discussed during OPTIMaDe workshop 2018 priority/mid There is a consensus that this have average priority to sort out. status/approved Consensus has been reached to implement this as described in the top comment. status/has-concrete-suggestion This issue has one or more concrete suggestions spelled out that can be brought up for consensus. topic/filtering-language Issue discussing changes and improvements to the query and filtering language topic/response-format Issue discussing changes and improvements to the API response format
Projects
None yet
Milestone
1.0 release
Development

Successfully merging a pull request may close this issue.

Updates to filtering language rartino/OPTIMADE
3 participants
@ltalirz @rartino @ctoher