Migrate CI from Travis to GitHub Actions #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml-evs
added
priority/low
ml-evs
force-pushed
the
ml-evs/ci_migration
branch
from
aebd192
to
0742b7a
Compare
merkys
reviewed
Nov 6, 2020
CasperWA
approved these changes
Nov 6, 2020
Comment on lines
+27
to
+28
| run: | | ||
| pre-commit run --all-files |
There was a problem hiding this comment.
Suggested change
| run: | | |
| pre-commit run --all-files | |
| run: pre-commit run --all-files |
Comment on lines
+24
to
+25
| run: | | ||
| pip install pre-commit==2.2.0 |
There was a problem hiding this comment.
Suggested change
| run: | | |
| pip install pre-commit==2.2.0 | |
| run: pip install pre-commit==2.2.0 |
There was a problem hiding this comment.
Maybe we should update this version to the latest version of 2.8.2?
Suggested change
| run: | | |
| pip install pre-commit==2.2.0 | |
| run: pip install pre-commit==2.8.2 |
CasperWA
requested changes
Nov 6, 2020
CasperWA
approved these changes
Nov 6, 2020
shyamd
approved these changes
Nov 6, 2020
Agree with all your suggestions, but to save another round of reviewing I'll merge this as is. I'll raise another issue tracking the swagger validation of schema in the CI and can fix those minor blips then. |
ml-evs
added a commit
that referenced
this pull request
Feb 16, 2021
* Added Java tests to GH actions * Renamed GH actions file
ml-evs
added a commit
that referenced
this pull request
Feb 26, 2021
* Added Java tests to GH actions * Renamed GH actions file
ml-evs
added a commit
that referenced
this pull request
May 30, 2021
* Added Java tests to GH actions * Renamed GH actions file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the Travis OSS billing changes mentioned in #331, this PR migrates the Java build and checks to GH actions. It seems to work perfectly...
We won't run out of Travis minutes for quite a while, so I've left Travis enabled until we're convinced the new Actions agree with Travis.
GitHub shows an ugly diff given the file rename, the actual changes are all in 4b14f26.
Downsides: more eggs in GH basket, but Travis is basically forcing our hand...