Update OpenAPI schemas according to OPTIMADE Python tools v0.13.3 #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CasperWA
added
PR/minor-fixes-only
PR/ready-for-review
merkys
approved these changes
Mar 4, 2021
|
I'm holding off reviewing this as I'm quite closely involved in the changes... |
So you don't agree with them? 😏 |
rartino
approved these changes
Mar 16, 2021
Intriguing. Will this implementation be part of a repo in this GH organization or is it something different? |
There will be a validator as part of the httk OPTIMADE implementation capable of validating responses based on a schema (there actually already was such a validator in the old optimade-python-candidate-reference-implementation...) |
ml-evs
pushed a commit
that referenced
this pull request
Apr 23, 2021
The related OPTIMADE Python tools PR: Materials-Consortia/optimade-python-tools#731. The changes are related to enumerations (Python Enum sub-classes), extending information about them and defining the default value for the aggregate field attribute for a links resource.
ml-evs
pushed a commit
that referenced
this pull request
May 30, 2021
The related OPTIMADE Python tools PR: Materials-Consortia/optimade-python-tools#731. The changes are related to enumerations (Python Enum sub-classes), extending information about them and defining the default value for the aggregate field attribute for a links resource.
rartino
pushed a commit
that referenced
this pull request
Jul 7, 2021
The related OPTIMADE Python tools PR: Materials-Consortia/optimade-python-tools#731. The changes are related to enumerations (Python Enum sub-classes), extending information about them and defining the default value for the aggregate field attribute for a links resource.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is yet another update to the OpenAPI schemas.
The changes are related to the update of the Python package used to create the schemas,
pydantic, where OPTIMADE Python tools now depends on the latest version (v1.8.1) instead of being fixed at an older version (v1.6).The related OPTIMADE Python tools PR: Materials-Consortia/optimade-python-tools#731.
The changes are related to enumerations (Python Enum sub-classes), extending information about them and defining the default value for the
aggregatefield attribute for alinksresource.