Formatting tweaks, JSON fixes and tabs->spaces #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml-evs
force-pushed
the
ml-evs/formatting
branch
from
77675cd
to
c34b8a0
Compare
|
I think this is happening because we have some mixed tabs/spaces in the specification... |
|
The diff also looks wrong now for code/JSON example sections. |
|
Yep, trying to fix this properly with expandtab now
…On Fri, 11 Jun 2021, 09:43 Casper Welzel Andersen, ***@***.***> wrote:
The diff also looks wrong now for code/JSON example sections.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#363 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB4MTYBGBHUJPJZS4YZJE3DTSHEBPANCNFSM46QHD4DA>
.
|
ml-evs
force-pushed
the
ml-evs/formatting
branch
from
cd9045d
to
6befa79
Compare
ml-evs
force-pushed
the
ml-evs/formatting
branch
2 times, most recently
from
fdb2c32
to
bce3cde
Compare
|
So I ended up going a bit overboard here, and have a script that can strip the JSON blocks out of the spec and validate them as JSON (a separate problem to the whitespace). This turned up lots of extra commas and missing quotes. I'm not sure if it's something that is worth adding to the CI itself as it is slightly manual (e.g. it skips our |
ml-evs
force-pushed
the
ml-evs/formatting
branch
from
c1a54e8
to
a206679
Compare
ml-evs
changed the title
- Manually fix some indentation
ml-evs
force-pushed
the
ml-evs/formatting
branch
from
a206679
to
3f18c45
Compare
CasperWA
reviewed
Jun 11, 2021
ml-evs
force-pushed
the
ml-evs/formatting
branch
from
956c385
to
ea9fa69
Compare
shyamd
previously approved these changes
Jun 11, 2021
CasperWA
approved these changes
Jun 11, 2021
shyamd
approved these changes
Jun 11, 2021
rartino
pushed a commit
that referenced
this pull request
Jul 7, 2021
* Two formatting tweaks * Tabs to spaces and check in CI * Remove additional commas and add missing quotes in JSON samples - Manually fix some indentation * Turned note back into a quote * Fix indentation for final example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just reading through the rendered spec on GitHub and found a couple of indents that are being treated as
where I don't think it was intentional.
Please check the rich diff to confirm this (the button is at the top right of the files changed window)