Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support fuzzy comparison lists #415

Merged
merged 8 commits into from
Jun 15, 2022
Merged

Support fuzzy comparison lists #415

merged 8 commits into from
Jun 15, 2022

Conversation

merkys
Copy link
Member

@merkys merkys commented Jun 2, 2022

Fixes #393 by allowing FuzzyStringOpRhs in list comparisons and zip comparisons. All additions in this PR are OPTIONAL.

@merkys merkys added topic/filtering-language Issue discussing changes and improvements to the query and filtering language type/proposal Proposal for addition/removal of features. May need broad discussion to reach consensus. status/has-concrete-suggestion This issue has one or more concrete suggestions spelled out that can be brought up for consensus. PR/ready-for-review Add this flag if you are the author of the PR and you want it to be reviewed. Remove it when editing labels Jun 2, 2022
@merkys merkys removed the status/has-concrete-suggestion This issue has one or more concrete suggestions spelled out that can be brought up for consensus. label Jun 2, 2022
rartino
rartino approved these changes Jun 6, 2022
View reviewed changes
Copy link
Contributor

@rartino rartino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and seems to work in grammatica, no reason not to merge this.

@blokhin blokhin mentioned this pull request Jun 7, 2022
Open
@rartino rartino requested a review from ml-evs June 14, 2022 13:06
ml-evs
ml-evs approved these changes Jun 14, 2022
View reviewed changes
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also makes sense to me from a grammar standpoint, though glad we don't have an example in the spec to encourage this kind of query!

@ml-evs ml-evs mentioned this pull request Jun 14, 2022
Open
@merkys merkys merged commit b33d141 into Materials-Consortia:develop Jun 15, 2022
@merkys merkys deleted the support-fuzzy-comparison-lists branch June 15, 2022 06:53
@ml-evs ml-evs mentioned this pull request Dec 5, 2022
Closed
@ml-evs ml-evs added this to the v1.2 milestone Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rartino rartino rartino approved these changes

@ml-evs ml-evs ml-evs approved these changes

@gmrigna gmrigna Awaiting requested review from gmrigna

@sauliusg sauliusg Awaiting requested review from sauliusg

@giovannipizzi giovannipizzi Awaiting requested review from giovannipizzi

Assignees
No one assigned
Labels
PR/ready-for-review Add this flag if you are the author of the PR and you want it to be reviewed. Remove it when editing topic/filtering-language Issue discussing changes and improvements to the query and filtering language type/proposal Proposal for addition/removal of features. May need broad discussion to reach consensus.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

Support substring comparisons on list elements
3 participants
@merkys @rartino @ml-evs