Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify encoding of OPTIMADE timestamp in property definitions. #444

Merged
merged 4 commits into from
Dec 22, 2022

Conversation

rartino
Copy link
Contributor

@rartino rartino commented Dec 22, 2022

Fix to resolve #443 by explaining how to encode a timestamp in a property definition.

optimade.rst Outdated Show resolved Hide resolved
optimade.rst Outdated Show resolved Hide resolved
optimade.rst Outdated Show resolved Hide resolved
ml-evs
ml-evs previously approved these changes Dec 22, 2022
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepting, pending the changes from @vaitkus' review.

Co-authored-by: Antanas Vaitkus <antanas.vaitkus90@gmail.com>
@ml-evs ml-evs added the blocking-release This is a PR or issue that presently blocks the release of next version of the spec. label Dec 22, 2022
@ml-evs ml-evs added this to the v1.2 milestone Dec 22, 2022
@rartino rartino merged commit bb6c464 into Materials-Consortia:develop Dec 22, 2022
@vaitkus vaitkus mentioned this pull request Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocking-release This is a PR or issue that presently blocks the release of next version of the spec.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Property definitions type for timestamp (and other non-json OPTIMADE types)
3 participants