Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of property definitions #1425

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Implementation of property definitions #1425

wants to merge 2 commits into from

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Dec 6, 2022 •
edited
Loading

Rough attempt to begin closing #1416. Still lots to do, and maybe to push back on upstream.

To-do:

  • Update entry info models with JSONSchema
  • Update OpenAPI schemas
  • Finalise all descriptions
  • Validation of fields, e.g., if type = "object", does the nested definition have the right type?
  • Convert existing OPTIMADE field definitions over to new format
  • Testing...
  • Docs
  • Hook into existing provider fields config to construct definitions

@ml-evs ml-evs added schema Concerns the schema models server Issues pertaining to the example server implementation models For issues related to the pydantic models directly on-hold For PRs/issues that are on-hold for an unspecified time OPTIMADE v1.2 This label describes actions that have to be taken to be complient with OPTIMADE 1.2 labels Dec 6, 2022
@ml-evs ml-evs added this to the OPTIMADE v1.2 milestone Dec 6, 2022
@ml-evs ml-evs mentioned this pull request Dec 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CasperWA CasperWA Awaiting requested review from CasperWA CasperWA will be requested when the pull request is marked ready for review CasperWA is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
models For issues related to the pydantic models directly on-hold For PRs/issues that are on-hold for an unspecified time OPTIMADE v1.2 This label describes actions that have to be taken to be complient with OPTIMADE 1.2 schema Concerns the schema models server Issues pertaining to the example server implementation
Projects
None yet
Milestone
OPTIMADE v1.2
Development

Successfully merging this pull request may close these issues.
1 participant
@ml-evs