Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add launch image iOS #12

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

SputNikPlop
Copy link

This adds a launch image to the app instead of keeping it entirely blank on startup.

@SputNikPlop
Copy link
Author

The app appears to have a gray box around the logo. Would it be possible @MateusRodCosta to modify the logo to make it whiter so it appears more natural?
Screenshot 2023-08-28 at 22 33 17

@MateusRodCosta
Copy link
Owner

The app appears to have a gray box around the logo. Would it be possible @MateusRodCosta to modify the logo to make it whiter so it appears more natural? Screenshot 2023-08-28 at 22 33 17

This is likely because I use #fafafa as the background color instead of #ffffff.
I think you will have to recreate the icon with transparent background from the svgs at the misc folder.

@MateusRodCosta MateusRodCosta added iOS Related to iOS native Related to native integration with the host OS labels Sep 2, 2023
@MateusRodCosta
Copy link
Owner

Hey, I took a quick look at your PR and apparently it focus only on iOS?

The app appears to have a gray box around the logo. Would it be possible @MateusRodCosta to modify the logo to make it whiter so it appears more natural?

I updated the icons just now on the dev branch, you will likely want one of the pngs that has either transparent or white background. The Google Play icon might also be an option since it adds scales down the icon to add some padding around it.

Do note that while you are handling iOS splash screen, there's also the need to do something for pre-Android 12.Android 12+ is optional since there is a default splash screen implementation.

In anyway, please create new PRs on top of the dev branch in the future.

@SputNikPlop
Copy link
Author

I updated the icons just now on the dev branch, you will likely want one of the pngs that has either transparent or white background. The Google Play icon might also be an option since it adds scales down the icon to add some padding around it.

I updated the PR with this, will try android and to the correct branch.

@SputNikPlop SputNikPlop changed the title feat: add launch image feat: add launch image iOS Sep 6, 2023
@MateusRodCosta MateusRodCosta changed the base branch from main to dev September 7, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS Related to iOS native Related to native integration with the host OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants