Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for TM 7.7.1 + big refactoring #46

Merged
merged 77 commits into from
Mar 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
77 commits
Select commit Hold shift + click to select a range
5697992
updates for supporting TM v7.6
gpetretto Jan 25, 2023
be487a6
Merge remote-tracking branch 'upstream/develop' into v76
gpetretto Jan 27, 2023
88a24ad
fix linting
gpetretto Jan 27, 2023
d59bc55
Updated version and documentation for 1.3.1 release.
davidwaroquiers Jan 30, 2023
ccdb34a
Update version of isort in .pre-commit-config
davidwaroquiers Jan 30, 2023
2e7d026
Update pyproject.toml
davidwaroquiers Jun 13, 2023
121727d
Update pyproject.toml
davidwaroquiers Feb 20, 2024
005a29f
Fixed comparison in test_files.
davidwaroquiers Feb 20, 2024
98bb24d
Fixed comparison utility function for tests.
davidwaroquiers Feb 20, 2024
f785190
Linting.
davidwaroquiers Feb 21, 2024
7e1eb57
Fixed import error of plotting function from pymatgen for py3.9+.
davidwaroquiers Feb 21, 2024
9943c2c
Updated docs html.
davidwaroquiers Feb 21, 2024
ceef5ad
Merge branch 'release_v1.3.1' into v76_fixes
davidwaroquiers Feb 21, 2024
50d800f
Added tests_config.yaml and TMV6 in list of tests to be performed.
davidwaroquiers Feb 21, 2024
da64ce1
Merge branch 'develop' into v76_fixes
davidwaroquiers Feb 21, 2024
bc340a8
Updated docs and version.
davidwaroquiers Feb 21, 2024
bd3ae44
Fixed aoforce parsing in TM 7.7.
davidwaroquiers Feb 21, 2024
b24639b
Fixed reading of coord file with "natoms= ..." in first line.
davidwaroquiers Feb 22, 2024
ec9189f
Fixed parsing of irrep_data for TM>=7.7.
davidwaroquiers Feb 22, 2024
72a2a17
Fixed escf parsing.
davidwaroquiers Feb 22, 2024
d8e2108
Updated reference files for integration tests.
davidwaroquiers Feb 22, 2024
0042103
Fixed is_uhf parsing method.
davidwaroquiers Feb 23, 2024
cad38e9
Generated new reference files for unit tests.
davidwaroquiers Feb 23, 2024
4f79ca7
Updated html docs and version.
davidwaroquiers Feb 23, 2024
8f69d3b
Updated checkout and setup-python actions in CI.
davidwaroquiers Feb 23, 2024
8e45681
Merge branch 'develop' into TM_V771
davidwaroquiers Mar 5, 2024
ba2a879
Big refactoring of turbomoleio.
davidwaroquiers Mar 7, 2024
d8f6816
Updated changelog.
davidwaroquiers Mar 7, 2024
19ee9dc
Removed python 3.8 from tests.
davidwaroquiers Mar 7, 2024
468f3ca
Trying to fix issue on CI with TEST_DATA defined in code instead of
davidwaroquiers Mar 8, 2024
c44c2a2
Fixing test_data in CI.
davidwaroquiers Mar 8, 2024
f6f13bb
Fixing test_data in CI.
davidwaroquiers Mar 8, 2024
320dba1
Fixing test_data in CI
davidwaroquiers Mar 8, 2024
3a2f8fe
Fixing version from src code in docs_rst/conf.py.
davidwaroquiers Mar 11, 2024
4c5358e
Linting tests.
davidwaroquiers Mar 11, 2024
0453625
Adding unit tests.
davidwaroquiers Mar 11, 2024
c60fd69
Added unit tests for control.py
davidwaroquiers Mar 11, 2024
9b7dab8
Adding unit tests.
davidwaroquiers Mar 11, 2024
cf2ab3b
Adding unit tests.
davidwaroquiers Mar 11, 2024
8578b3a
Adding unit tests.
davidwaroquiers Mar 11, 2024
db4bae1
Adding unit tests.
davidwaroquiers Mar 11, 2024
461787b
Adding unit tests.
davidwaroquiers Mar 11, 2024
2bdbb66
Added unit tests.
davidwaroquiers Mar 12, 2024
d5e288a
Added no branch.
davidwaroquiers Mar 12, 2024
b4bd6a1
Adding unit tests.
davidwaroquiers Mar 12, 2024
a674315
Adding unit tests.
davidwaroquiers Mar 12, 2024
8fb784d
Adding unit tests.
davidwaroquiers Mar 12, 2024
94dc12e
Adding unit tests.
davidwaroquiers Mar 12, 2024
ebeab48
Add fail_under = 100 for coverage.
davidwaroquiers Mar 12, 2024
76fc923
Adding unit tests.
davidwaroquiers Mar 12, 2024
aa450fb
Fixed addopts for pytest.
davidwaroquiers Mar 12, 2024
d69ce0e
Adding unit tests.
davidwaroquiers Mar 12, 2024
37f936f
Modified pytest execution in github ci workflow.
davidwaroquiers Mar 12, 2024
9c55b18
Adding unit tests.
davidwaroquiers Mar 12, 2024
9b30b1b
Trying to fix pytest ci coverage options.
davidwaroquiers Mar 12, 2024
0c7acd1
Unit tests + trying to fix pytest's CI workflow.
davidwaroquiers Mar 12, 2024
65fbd43
Trying to fix pytest ci ...
davidwaroquiers Mar 12, 2024
3c5af75
Trying to fix gh ci.
davidwaroquiers Mar 12, 2024
7d8d7d2
Trying to fix gh ci wf file.
davidwaroquiers Mar 12, 2024
aa9fb2f
Fixed available_templates to be returned as alphabetical
davidwaroquiers Mar 12, 2024
8b4bdfa
Adding unit tests.
davidwaroquiers Mar 12, 2024
5e2b292
Adding unit tests.
davidwaroquiers Mar 12, 2024
6451aa1
Adding unit tests.
davidwaroquiers Mar 12, 2024
34a05bf
Adding no branch.
davidwaroquiers Mar 12, 2024
76c071f
Adding unit tests.
davidwaroquiers Mar 12, 2024
695a96e
Adding no branch.
davidwaroquiers Mar 12, 2024
2b48de0
Adding unit tests for run_itest.
davidwaroquiers Mar 13, 2024
a3204e8
Moving imports upwards + small change in run_itest.
davidwaroquiers Mar 13, 2024
8925e9d
Adding unit tests.
davidwaroquiers Mar 13, 2024
be6cd44
Added references for run_itest.
davidwaroquiers Mar 13, 2024
0b62273
Fixes + updates of reference files.
davidwaroquiers Mar 13, 2024
2b71559
Fixed zip strict for python 3.9.
davidwaroquiers Mar 14, 2024
6c7208d
Added no cover for dryrun and generation in run_itest.
davidwaroquiers Mar 14, 2024
4e1e9bf
Added unit tests.
davidwaroquiers Mar 14, 2024
ed41599
Added unit test to get 100% coverage in py3.9.
davidwaroquiers Mar 14, 2024
bb135c7
Updates following GP's review.
davidwaroquiers Mar 27, 2024
5bc7aa3
Updated release date + updated documentation.
davidwaroquiers Mar 27, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
35 changes: 15 additions & 20 deletions .github/workflows/main_ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
- name: Set up Python 3.8
uses: actions/setup-python@v1
- uses: actions/checkout@v4
- name: Set up Python 3.9
uses: actions/setup-python@v5
with:
python-version: '3.8'
python-version: '3.9'
- name: Linting
run: |
pip install pre-commit
Expand All @@ -27,28 +27,23 @@ jobs:
strategy:
max-parallel: 2
matrix:
python-version: ['3.8', '3.9', '3.10']
python-version: ['3.9', '3.10', '3.11']
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v2
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
cache: pip
cache-dependency-path: pyproject.toml

- name: Get full python version
id: full-python-version
shell: bash
run: echo ::set-output name=version::$(python -c "import sys; print('-'.join(str(v) for v in sys.version_info))")

- name: Install pytest
shell: bash
run: pip install pytest

- name: Install turbomoleio
shell: bash
run: pip install .
- name: Install dependencies
run: |
python -m pip install --upgrade pip
python -m pip install .[dev]

- name: Run pytest
shell: bash
run: pytest -m 'not integration'
run: pytest --cov=turbomoleio --cov-report=xml -m "not integration"
# run: pytest -m 'not integration'
24 changes: 14 additions & 10 deletions dev_scripts/generate_output_files.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import os
import shutil
import sys
from pathlib import Path

from monty.os import cd, makedirs_p
from monty.serialization import dumpfn, loadfn
Expand All @@ -45,17 +46,20 @@
from turbomoleio.input.utils import get_define_template
from turbomoleio.output.files import EscfOnlyOutput, JobexOutput, exec_to_out_obj
from turbomoleio.output.parser import Parser
from turbomoleio.testfiles.utils import (
from turbomoleio.testing import (
PARSER_METHODS,
TESTDIR,
TM_VERSIONS,
compare_differences,
generate_control_for_test,
generate_reference_output,
)

gen_dir = os.path.join(TESTDIR, "outputs", "generation")
OUTPUTS_BASENAMES = loadfn(os.path.join(gen_dir, "tests_config.yaml"))["testlist"]
module_dir = Path(__file__).resolve().parent.parent
TEST_DATA = module_dir / "tests" / "test_data"
TEST_DATA = TEST_DATA.resolve()

gen_dir = TEST_DATA / "outputs" / "generation"
OUTPUTS_BASENAMES = loadfn(gen_dir / "tests_config.yaml")["testlist"]
exec_to_out_obj = dict(exec_to_out_obj)
exec_to_out_obj["jobex"] = JobexOutput

Expand Down Expand Up @@ -247,8 +251,8 @@ def get_version_dir(version_dir, force, compare_to):
print(f"Turbomole version {tm_version} detected")
if not version_dir:
version_dir = f"TM_v{tm_version}"
vdir_path = os.path.join(TESTDIR, "outputs", version_dir)
if not force and os.path.exists(vdir_path):
vdir_path = TEST_DATA / "outputs" / version_dir
if not force and vdir_path.exists():
print(
"Directory exists. If generation of existing tests is performed, "
"code will exit. Use --force to overwrite."
Expand All @@ -259,10 +263,10 @@ def get_version_dir(version_dir, force, compare_to):
f"<testfiles/outputs/{version_dir}>."
)
if compare_to is None:
ref_vdir_path = os.path.join(TESTDIR, "outputs", TM_VERSIONS[-1])
ref_vdir_path = TEST_DATA / "outputs" / TM_VERSIONS[-1]
else:
ref_vdir_path = os.path.join(TESTDIR, "outputs", compare_to)
if not os.path.exists(ref_vdir_path):
ref_vdir_path = TEST_DATA / "outputs" / compare_to
if not ref_vdir_path.exists():
print("Reference version directory does not exist")
exit()
return vdir_path, ref_vdir_path
Expand Down Expand Up @@ -641,7 +645,7 @@ def update_json_files(dryrun, rtol, atol, print_diffs):
"""
print("Updating json files")
for tm_version in TM_VERSIONS:
vdir_path = os.path.join(TESTDIR, "outputs", tm_version)
vdir_path = os.path.join(TEST_DATA, "outputs", tm_version)
vdir_testlist = loadfn(os.path.join(vdir_path, "tests_config.yaml"))["testlist"]
version_all_diffs = {}
for tm_exec, testnames in vdir_testlist.items():
Expand Down
23 changes: 6 additions & 17 deletions docs/_modules/index.html
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<!DOCTYPE html>
<html class="writer-html5" lang="en">
<html class="writer-html5" lang="en" data-content_root="../">
<head>
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Overview: module code &mdash; turbomoleio 1.4.0 documentation</title>
<title>Overview: module code &mdash; turbomoleio 1.5.0 documentation</title>
<link rel="stylesheet" type="text/css" href="../_static/pygments.css?v=fa44fd50" />
<link rel="stylesheet" type="text/css" href="../_static/css/theme.css?v=19f00094" />

Expand All @@ -14,9 +14,9 @@

<script src="../_static/jquery.js?v=5d32c60e"></script>
<script src="../_static/_sphinx_javascript_frameworks_compat.js?v=2cd50e6c"></script>
<script data-url_root="../" id="documentation_options" src="../_static/documentation_options.js?v=b308ce55"></script>
<script src="../_static/documentation_options.js?v=e0a75244"></script>
<script src="../_static/doctools.js?v=888ff710"></script>
<script src="../_static/sphinx_highlight.js?v=4825356b"></script>
<script src="../_static/sphinx_highlight.js?v=dc90522c"></script>
<script src="../_static/js/theme.js"></script>
<link rel="index" title="Index" href="../genindex.html" />
<link rel="search" title="Search" href="../search.html" />
Expand All @@ -34,7 +34,7 @@
turbomoleio
</a>
<div class="version">
1.4.0
1.5.0
</div>
<div role="search">
<form id="rtd-search-form" class="wy-form" action="../search.html" method="get">
Expand Down Expand Up @@ -97,25 +97,14 @@ <h1>All modules for which code is available</h1>
<li><a href="turbomoleio/core/datagroups.html">turbomoleio.core.datagroups</a></li>
<li><a href="turbomoleio/core/molecule.html">turbomoleio.core.molecule</a></li>
<li><a href="turbomoleio/core/periodic.html">turbomoleio.core.periodic</a></li>
<li><a href="turbomoleio/core/tests/test_control.html">turbomoleio.core.tests.test_control</a></li>
<li><a href="turbomoleio/core/tests/test_datagroups.html">turbomoleio.core.tests.test_datagroups</a></li>
<li><a href="turbomoleio/core/tests/test_molecule.html">turbomoleio.core.tests.test_molecule</a></li>
<li><a href="turbomoleio/core/tests/test_periodic.html">turbomoleio.core.tests.test_periodic</a></li>
<li><a href="turbomoleio/core/tests/test_utils.html">turbomoleio.core.tests.test_utils</a></li>
<li><a href="turbomoleio/core/utils.html">turbomoleio.core.utils</a></li>
<li><a href="turbomoleio/input/define.html">turbomoleio.input.define</a></li>
<li><a href="turbomoleio/input/tests/test_define.html">turbomoleio.input.tests.test_define</a></li>
<li><a href="turbomoleio/input/tests/test_utils.html">turbomoleio.input.tests.test_utils</a></li>
<li><a href="turbomoleio/input/templates.html">turbomoleio.input.templates</a></li>
<li><a href="turbomoleio/input/utils.html">turbomoleio.input.utils</a></li>
<li><a href="turbomoleio/output/data.html">turbomoleio.output.data</a></li>
<li><a href="turbomoleio/output/files.html">turbomoleio.output.files</a></li>
<li><a href="turbomoleio/output/parser.html">turbomoleio.output.parser</a></li>
<li><a href="turbomoleio/output/states.html">turbomoleio.output.states</a></li>
<li><a href="turbomoleio/output/tests/test_data.html">turbomoleio.output.tests.test_data</a></li>
<li><a href="turbomoleio/output/tests/test_files.html">turbomoleio.output.tests.test_files</a></li>
<li><a href="turbomoleio/output/tests/test_parser.html">turbomoleio.output.tests.test_parser</a></li>
<li><a href="turbomoleio/output/tests/test_states.html">turbomoleio.output.tests.test_states</a></li>
<li><a href="turbomoleio/testfiles/utils.html">turbomoleio.testfiles.utils</a></li>
</ul>

</div>
Expand Down
Loading