Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed version of numpy to less than 2. #48

Merged
merged 1 commit into from
Jul 27, 2024
Merged

Fixed version of numpy to less than 2. #48

merged 1 commit into from
Jul 27, 2024

Conversation

davidwaroquiers
Copy link
Member

No description provided.

gpetretto
gpetretto approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@gpetretto gpetretto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fine. But at some point we will need to address this. Does this break many parts of the code?

@davidwaroquiers
Copy link
Member Author

Yes I first thought to just make sure it works, maybe we can have it to work both with old and new numpy

@davidwaroquiers davidwaroquiers merged commit db74669 into develop Jul 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpetretto gpetretto gpetretto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidwaroquiers @gpetretto