Fixed inheritance of intracellular from default dell definition #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcorusc
force-pushed
the
fix/cell_definition_intracellular
branch
from
8acafda to
0b4bde1
Compare
…n the cell definition --> cell types with no maboss model no longer inherit it from the default one
marcorusc
force-pushed
the
fix/cell_definition_intracellular
branch
from
0b4bde1 to
bede990
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Paul!
I have added in PhysiCell_cell.cpp an if/else sentence to set to NULL phenotype.intracellular in case one or more cell definitions in the xml have no intracellular module.
Since in the GUI we do not want any inheritance from one cell definition to another, we need to make sure that in mixed models (where some cell types have a maboss model and other ones don't) cell types with no maboss model will not inherit from previous ones, and so phenotype.intracellular will stay == NULL.
I hope this explanation is not too much confusing, otherwise I can try to explain myself better...