Update Dependencies and Refactor Code for zip Crate Breaking Changes #245
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request: Update Dependencies and Refactor Code for
zip
Crate Breaking ChangesThis pull request updates the project's dependencies to their latest versions, addressing breaking changes introduced by the
zip
crate. Additionally, the codebase has been refactored to accommodate these changes and align with current Rust practices.Key Changes
Dependency Updates
hashbrown
:0.14.5
→0.15.2
quick-xml
:0.36.2
→0.37.1
zip
:1.1.4
→2.2.1
Refactoring
WriterManager
struct and related methods have been updated to work with a mutable reference toZipWriter
instead of consuming it directly. This improves flexibility and reduces unnecessary ownership overhead.Cells
logic to replaceinsert_unique_unchecked
withHashMap::insert
, improving safety and aligning with standard practices.Added
resolver = "2"
Cargo.toml
to resolve compatibility issues caused by dependency version conflicts.Known Issue:
wasm-bindgen
Bug Prevents BuildCurrently, the code does not build due to a critical bug introduced in the
wasm-bindgen
crate. The issue stems from a dependency chain as shown below:To fix this issue manually, the following change is required:
Additional Notes
This
wasm-bindgen
bug also affects themain
branch as it stands, so enablingresolver = "2"
is necessary for both themain
branch and this PR.Once the upstream issue in
wasm-bindgen
is resolved, this branch should build correctly without further intervention.