Integrate changes for release 2.1.0 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed bug that caused the AudioManagerSettings to make NullReferenceExpection, because when restarting a scene that contains one it attempted to create another one overwriting the old one and deleting the AudioSources.
Added custom decorator called FluentAudioManager that allows using the underlying methods as a fluent interface. Meaning multiple methods can be chained into one line. Where an error will result in the following methods in the chain being skipped.
Added new method to deregister children once they are not needed anymore and adjusted RemoveSound to delete the children as well as the underlying AudioSources in the scene.
Codecov Report
@@ Coverage Diff @@
## main #4 +/- ##
==========================================
+ Coverage 99.86% 99.88% +0.02%
==========================================
Files 14 16 +2
Lines 1447 1728 +281
==========================================
+ Hits 1445 1726 +281
Misses 2 2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.