Refactor axes #74
Merged
Refactor axes #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function wasn't changing the position of the axes, so it was unecessary / had a bug. I believe re-positioning the axes after camera rotations can never be perfect, therefore the user has a better experience if there is no axes re-positioning. For axes re-positioning be perfect, the axes should NEVER be behind any object in the scene, what is very hard to do / impossible.
TiagoCavalcante
force-pushed
the
refactor-axes
branch
3 times, most recently
from
f05c811 to
b270ddc
Compare
|
I'll merge it now before it gets too big. Further changes are coming in other PRs. |
Update CHANGES.md.
It was used only in 1 place, and it was replaced by "hard-coded" indices (0, 1, 2, 3, 4, 5).
Update the reference image for axes.html.
TiagoCavalcante
force-pushed
the
refactor-axes
branch
from
b270ddc to
bb930b7
Compare
This is closer to Wolfram Language bahaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.