Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do more darty things like use libraries and packages #1

Closed
wants to merge 1 commit into from
Closed

do more darty things like use libraries and packages #1

wants to merge 1 commit into from

Conversation

sethladd
Copy link
Collaborator

Also, commit the build directory so people can just clone and run.

@sethladd
Copy link
Collaborator Author

I have no idea why I was in the gh-pages branch. Not sure if that's the right place to be?

@MathieuLorber
Copy link
Owner

I updated my gh-pages before working on my last PR which is a dedicated branch, so I think you've worked on the previous version of the code. After your reviews I did another branch to make several commits without polluting the initial PR. Can you try to make your PR on my 'codeReview' branch ? If you can't I'll make the merge.

@ghost ghost assigned MathieuLorber Dec 13, 2013
@MathieuLorber
Copy link
Owner

About UUID, I used https://github.com/Daegalus/dart-uuid on my last PR, instead of implementing it. But it increase consistently the final weight of the compiled app. WDYT is the best solution ?

@MathieuLorber
Copy link
Owner

I gave you write rights on my repo, do what is the simplest for you...

@sethladd
Copy link
Collaborator Author

re: UUID, normally I recommend a package (code reuse ftw!) but I thought it made a good example of how you would do a library in an app.

Let me see if I can get these branches under control. :)

@sethladd
Copy link
Collaborator Author

There's no dart dir in codeReview's architecture-examples directory.

@sethladd
Copy link
Collaborator Author

nm, I see vanilla-examples now. gotcha! :)

@sethladd
Copy link
Collaborator Author

Closing because this was on the wrong branch.

@sethladd sethladd closed this Dec 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants