Create media directory if it doesn't exist #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The decision to use `create_dir` instead of `create_dir_all` was a conscience one. I don't think we should be creating the output dir because that could cause a person to create incorrect directories by mistake that they didn't intend to i.e using --output=/abc instead of the intended --output=abc This is the same behavior curl takes with its --output-dir option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The decision to use
create_dirinstead ofcreate_dir_allwas aconscience one. I don't think we should be creating the output dir
because that could cause a person to create incorrect directories by
mistake that they didn't intend to i.e using --output=/abc instead of
the intended --output=abc
This is the same behavior curl takes with its --output-dir option.