Add the block id as an id attribute to all rendered blocks #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The decision to link to the wrapper div instead of the paragraph itself was made because currently when a link to a paragraph which has children is taken on Notion, Notion highlights both the paragraph and its children. I went back and forth on this decision however so if linking to the paragraph directly proves more useful we should go for it. Linking to paragraphs directly feels more intuitive to me anyway
The decision to put the id on the list items instead of the lists themselves is a fairly obvious one to me. No idea how would one put them on the lists anyway
I put the id on the figure instead of the img tag because I think they act as one entity and linking to the whole thing makes most sense This is as opposed to lists where each item acts independently
Same as images here, the whole thing is one unified thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The decision to remove the dashes from the id is based on
#28c719a398454f089e871fe78e50e92b)#28c719a3-9845-4f08-9e87-1fe78e50e92b) selecting the whole thing becomes a pain due to browsers considering dashes as word breaks. So double clicking selects only the segment between the two dashes instead of the whole thing."/46f8638c25a84ccd9d926e42bdb5535e#28c719a398454f089e871fe78e50e92b"AKA/PAGE_ID_WITHOUT_DASHES#BLOCK_ID_WITHOUT_DASHES