Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration testing refactor stage 1 #82

Merged
merged 5 commits into from
Dec 19, 2023

Conversation

tegefaulkes
Copy link
Contributor

@tegefaulkes tegefaulkes commented Dec 18, 2023

Description

This PR addresses refactoring integration testing.

Issues Fixed

Tasks

  • 1. All the standard tests will no attempt connections to any network. They should explicitly be started with no seed nodes.
  • 2. The integration tests will be separated from the standard tests.
    • 1. remove usage of the testif utility from the standard tests.
    • 2. integration tests will be in a separate folder structure from the standard tests.
    • 3. integration tests will focus on connecting to the testnet.
  • 3. integration tests need to wait for the testnet to be updated. to this end the following changes are to be made.
    • 1. CLI ci job for for triggering the testnet seed nodes using the new image will be removed. This will be handled by the testnet infrastructure.
    • 2. A job will be created to wait for the seed nodes to switch to the new version. This will be done by polling a polykey dashboard endpoint that will either return the when all seednodes have been updated, or list the versions of all the seed nodes. This will need to be speced out.

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@tegefaulkes tegefaulkes self-assigned this Dec 18, 2023
@ghost
Copy link

ghost commented Dec 18, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Only integration testing should attempt any network connections.

[ci skip]
@tegefaulkes
Copy link
Contributor Author

I'm going to merge this with the changes for parts 1 and 2. Once merged I can fix any problems with the CI and move forward with fixing that.

Part 3 will be addressed in a follow up PR.

@tegefaulkes tegefaulkes changed the title Integration testing refactor Integration testing refactor stage 1 Dec 19, 2023
@tegefaulkes tegefaulkes force-pushed the feature-integration-test-refactor branch from 9614a48 to d6a87a3 Compare December 19, 2023 04:53
@tegefaulkes tegefaulkes merged commit 315566e into staging Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant