Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating .proto definition subdomains. #279

Closed
2 tasks done
tegefaulkes opened this issue Oct 29, 2021 · 4 comments · Fixed by #280
Closed
2 tasks done

Creating .proto definition subdomains. #279

tegefaulkes opened this issue Oct 29, 2021 · 4 comments · Fixed by #280
Assignees
Labels
development Standard development epic Big issue with multiple subissues

Comments

@tegefaulkes
Copy link
Contributor

tegefaulkes commented Oct 29, 2021

Specification

We need to update the protobuf definitions to split up messages for each domain into its own domain .proto file. we can use package names and imports to achieve this.

Additional context

Relates to #249

Tasks

  • Prototype by abstracting into subdirectories under src/proto/schemas, and integrate google's protobuf library by first referencing it and then just copying verbatim
  • Create common domain types and common message types and share between Client.proto and Agent.proto
@tegefaulkes tegefaulkes mentioned this issue Oct 29, 2021
14 tasks
@tegefaulkes tegefaulkes changed the title - Prototype by abstracting into subdirectories under src/proto/schemas, and integrate google's protobuf library by first referencing it and then just copying verbatim Creating .proto definition subdomains. Oct 29, 2021
This was referenced Oct 29, 2021
tegefaulkes added a commit that referenced this issue Oct 29, 2021
…t for `google.protobuf` message types. Fixes (#279)
tegefaulkes added a commit that referenced this issue Oct 29, 2021
…t for `google.protobuf` message types. Fixes (#279)
@CMCDragonkai
Copy link
Member

Remember to assign yourself here and put it in right column too.

Also I think tick boxes for issues should only relate to the issue, other items go to the PR.

@CMCDragonkai CMCDragonkai added epic Big issue with multiple subissues development Standard development labels Nov 1, 2021
@CMCDragonkai
Copy link
Member

Also I noticed this issue didn't have the labels automatically applied. Did you create the issue on github?

@tegefaulkes
Copy link
Contributor Author

I think I created it from a task list in the related issue.

@CMCDragonkai
Copy link
Member

Yea if aren't directly creating issues, make sure to add the appropriate labels and metadata.

CMCDragonkai pushed a commit that referenced this issue Nov 1, 2021
CMCDragonkai pushed a commit that referenced this issue Nov 1, 2021
CMCDragonkai pushed a commit that referenced this issue Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Standard development epic Big issue with multiple subissues
Development

Successfully merging a pull request may close this issue.

2 participants