-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding timeout overrides to NodeConnectionManager
methods
#363
Comments
Didn't really need an issue for this since it's a small change. But it leaves a paper trail for discussion. I'm in the process of adding the timeout to the methods such as |
Some of those methods could an async generator right? |
Yeah, withConnG is an async gen, the others are normal. |
In some cases we want to specify how long we attempt to connect to a node on a per-connection basis. Related #363
In some cases we want to specify how long we attempt to connect to a node on a per-connection basis. Related #363
In some cases we want to specify how long we attempt to connect to a node on a per-connection basis. Related #363
In some cases we want to specify how long we attempt to connect to a node on a per-connection basis. Related #363
In some cases we want to specify how long we attempt to connect to a node on a per-connection basis. Related #363
I'm going to update this to use timers instead of a timeout value. this way we can compose timeouts. |
In some cases we want to specify how long we attempt to connect to a node on a per-connection basis. Related #363
Fixed up the timeouts to use timers. |
In some cases we want to specify how long we attempt to connect to a node on a per-connection basis. Related #363
In some cases we want to specify how long we attempt to connect to a node on a per-connection basis. Related #363
In some cases we want to specify how long we attempt to connect to a node on a per-connection basis. Related #363
In some cases we want to specify how long we attempt to connect to a node on a per-connection basis. Related #363
The resolution of this issue should allow for #353 to be easily completed since it will allow for a timeout to be set for the |
In some cases we want to specify how long we attempt to connect to a node on a per-connection basis. Related #363
In some cases we want to specify how long we attempt to connect to a node on a per-connection basis. Related #363
In some cases we want to specify how long we attempt to connect to a node on a per-connection basis. Related #363
In some cases we want to specify how long we attempt to connect to a node on a per-connection basis. Related #363
In some cases we want to specify how long we attempt to connect to a node on a per-connection basis. Related #363
In some cases we want to specify how long we attempt to connect to a node on a per-connection basis. Related #363
In some cases we want to specify how long we attempt to connect to a node on a per-connection basis. Related #363
In some cases we want to specify how long we attempt to connect to a node on a per-connection basis. Related #363
Specification
While we can specify the timeouts when creating a
NodeConnectionManager
there are cases where we want to be able to specify a timeout when creating a connection.For this we will need to add an optional
connConnectTime
parameter to anyNodeConnectionManager
method that can create a connection. this ill override the timeout of trying to create a connection if set.Additional context
NodeGraph
#322 needs this to avoid blocking for a long time when checking a node.Tasks
NodeConnectionManager
methods that could create a new connection.The text was updated successfully, but these errors were encountered: