Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: node discovery warning message spam #514

Closed
tegefaulkes opened this issue Mar 19, 2023 · 8 comments · Fixed by #509
Closed

fix: node discovery warning message spam #514

tegefaulkes opened this issue Mar 19, 2023 · 8 comments · Fixed by #509
Assignees
@tegefaulkes
Labels
development Standard development r&d:polykey:core activity 3 Peer to Peer Federated Hierarchy

Comments

@tegefaulkes
Copy link
Contributor

Specification

When providing no seed nodes to connect to we would end up with logger warning messages Failed to connect to any seed nodes when syncing node graph. Since a lot of tests start a PolykeyAgent with no seed nodes provided, this ended up with a lot of useless warning messages during tests.

This can be fixed by checking if there are any provided seed nodes and skip discovery if none are provided.

Additional context

Tasks

  1. Skip discovery if no seeds nodes are provided to the NodeManager.
@tegefaulkes tegefaulkes added the development Standard development label Mar 19, 2023
@tegefaulkes tegefaulkes self-assigned this Mar 19, 2023
@tegefaulkes tegefaulkes mentioned this issue Mar 19, 2023
Merged
24 tasks
tegefaulkes added a commit that referenced this issue Mar 19, 2023
@tegefaulkes
fix: changing order of discovery message spam fix
da2200f 
* Related #514

[ci skip]
@tegefaulkes
Copy link
Contributor Author

tegefaulkes commented Mar 20, 2023 •
edited
Loading

Moved comment, ignore this.

5 similar comments
@tegefaulkes
Copy link
Contributor Author

tegefaulkes commented Mar 20, 2023 •
edited
Loading

Moved comment, ignore this.

@tegefaulkes
Copy link
Contributor Author

tegefaulkes commented Mar 20, 2023 •
edited
Loading

Moved comment, ignore this.

@tegefaulkes
Copy link
Contributor Author

tegefaulkes commented Mar 20, 2023 •
edited
Loading

Moved comment, ignore this.

@tegefaulkes
Copy link
Contributor Author

tegefaulkes commented Mar 20, 2023 •
edited
Loading

Moved comment, ignore this.

@tegefaulkes
Copy link
Contributor Author

tegefaulkes commented Mar 20, 2023 •
edited
Loading

Moved comment, ignore this.

@tegefaulkes
Copy link
Contributor Author

I have been commenting on the wrong issue. Let me fix that...

@tegefaulkes tegefaulkes mentioned this issue Mar 20, 2023
Closed
3 tasks
tegefaulkes added a commit that referenced this issue Mar 21, 2023
@tegefaulkes
fix: changing order of discovery message spam fix
d469d1f 
* Related #514

[ci skip]
@tegefaulkes
Copy link
Contributor Author

This was an opportunistic fix to prevent a bunch of logger warning messages during testing. Strictly speaking, failing to connect to all of the seed nodes is concerning. Not having any seeds nodes to connect to is not.

Example of logger messages from testing, specifically Failed to connect to any seed nodes when syncing node graph.

WARN:agentUnlock test.NodeManager:Failed to connect to any seed nodes when syncing node graph
WARN:agentUnlock test:Failed to verify identity claim between v07bvphcua9efa29q9dl5ro7taqkkik59oei5roeab45evfn40i60 and ["test-provider","trusted-node"]
WARN:agentUnlock test.NodeManager:Failed to connect to any seed nodes when syncing node graph
WARN:agentUnlock test.NodeManager:Failed to connect to any seed nodes when syncing node graph
WARN:agentUnlock test:Failed to verify identity claim between v5j6hiij5sspo0g6l2ue2adtgstvl82cmtcjgdu1t3odf1d9kinig and ["test-provider","trusted-node"]
WARN:agentUnlock test:Failed to verify identity claim between v5j6hiij5sspo0g6l2ue2adtgstvl82cmtcjgdu1t3odf1d9kinig and ["test-provider","trusted-node"]
WARN:agentUnlock test.NodeManager:Failed to connect to any seed nodes when syncing node graph
WARN:NodeManager:Failed to connect to any seed nodes when syncing node graph
WARN:agentUnlock test.NodeManager:Failed to connect to any seed nodes when syncing node graph
WARN:agentUnlock test.NodeManager:Failed to connect to any seed nodes when syncing node graph

@CMCDragonkai CMCDragonkai added the r&d:polykey:core activity 3 Peer to Peer Federated Hierarchy label Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tegefaulkes tegefaulkes

Labels
development Standard development r&d:polykey:core activity 3 Peer to Peer Federated Hierarchy
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Client RPC migration MatrixAI/Polykey
2 participants
@CMCDragonkai @tegefaulkes