Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General Data Validation - Boundary IO locations should be doing data validation and marshalling (and the decommissioning of GenericIdTypes for all IDs) #321

Merged
merged 8 commits into from
Feb 7, 2022
Merged

General Data Validation - Boundary IO locations should be doing data validation and marshalling (and the decommissioning of GenericIdTypes for all IDs) #321

merged 8 commits into from
Feb 7, 2022
+2,094 −824

Commits on Feb 6, 2022

  1. Integrated js-id for ClaimId and ClaimIdEncoded, where ClaimIdEncoded… 

    … is base32hex
    @CMCDragonkai
    CMCDragonkai committed Feb 6, 2022
    Configuration menu
    Copy the full SHA
    e791c9c View commit details
    Browse the repository at this point in the history

  2. Integrated js-id for PermissionId and PermissionIdString, where Permi… 

    …ssionIdString is the binary string form
    @CMCDragonkai
    CMCDragonkai committed Feb 6, 2022
    Configuration menu
    Copy the full SHA
    1f1ed64 View commit details
    Browse the repository at this point in the history

  3. Integrated js-id for NotificationId, no need to use GenericIdTypes

    @CMCDragonkai
    CMCDragonkai committed Feb 6, 2022
    Configuration menu
    Copy the full SHA
    fc6f510 View commit details
    Browse the repository at this point in the history

  4. Refactored decodeNodeId to return undefined if it cannot decode

    @CMCDragonkai
    CMCDragonkai committed Feb 6, 2022
    Configuration menu
    Copy the full SHA
    f11b632 View commit details
    Browse the repository at this point in the history

  5. Moved networkUtils.certNodeId to keysUtils.certNodeId

    @CMCDragonkai
    CMCDragonkai committed Feb 6, 2022
    Configuration menu
    Copy the full SHA
    16b5bd7 View commit details
    Browse the repository at this point in the history

  6. Exceptions outside ErrorPolykey are wrapped in ErrorPolykey when sent… 

    … over the network
    @CMCDragonkai
    CMCDragonkai committed Feb 6, 2022
    Configuration menu
    Copy the full SHA
    0985f1d View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2022

  1. General data validation on all IO boundaries including client and age… 

    …nt service handlers and CLI bin parsers
    @CMCDragonkai
    CMCDragonkai committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    134ad24 View commit details
    Browse the repository at this point in the history

  2. Use function expression for statusReplacer and statusReviver in o… 

    …rder to encode the raw `NodeId` before `toJSON` method is called on `IdInternal`
    @CMCDragonkai
    CMCDragonkai committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    cf54df9 View commit details
    Browse the repository at this point in the history