fix: bug with GPRC client call through proxy #370
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to address the issue with #369 and other small fixes.
This is basically the fix:
We couldn't get
pause
orcork
to work. So now we only start piping the server socket to the tls socket on the reverse side upon first receiving data.Issues Fixed
Tasks
RST_stream
GRPC bug. Do this by delaying any response through the proxy till after we receive the MAGIC frame.handleConnectForward
for the wild card addresses since they should not be connectable. - this could be done inProxy.establishConnectionForward
because it is used by bothhandleConnectForward
andopenConnectionForward
, and it would throw a specific exception for this. Have a look atsrc/network/errors.ts
to see what is acceptable.Proxy.test.ts
NodeConnection.name
is embedded in theNodeConnection
logger.NodeConnectionManager
to be less confusing when creating and using connections.Final checklist