Decentralizing the validation domain #573
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR decentralizes the validation domain avoiding a nexus point SPOF. Some changes to import paths will be expected.
Issues Fixed
Tasks
parseX
insidesrc/validation/utils.ts
into their respective domains.domain/utils.ts
they should import thesrc/validation/errors.ts
asvalidationErrors
, seesrc/claims/utils.ts
to see how to do this.src/validation/utils.ts
should now be usingdomainUtils.parseX
instead avoiding a centralised import onvalidation
domain as a "many to many" nexus in our codebase.[ ] 4. We can move the- not going to do this, it's fine the way it issrc/validation/index.ts
functions intosrc/validation/utils.ts
and re-export it unscoped insidesrc/validation
, allowing one toimport { validate, validateSync } from '../validation';
.Final checklist