Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing file tree serialisation utilities #774

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Implementing file tree serialisation utilities #774

merged 1 commit into from
Jul 26, 2024

Conversation

tegefaulkes
Copy link
Contributor

@tegefaulkes tegefaulkes commented Jul 17, 2024 •
edited
Loading

Description

This PR addresses creating a seraliser/de-serialiser for sending a file tree over the RPC.

Issues Fixed

Tasks

  • 1. Implement the seraliser. It needs to create a binary stream that includes all the file tree details as needed. It also needs to encode file data contents efficiently.
  • 2. Implement the deseraliser/parser.
  • 3. Create tests for these utilities.

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@tegefaulkes tegefaulkes self-assigned this Jul 17, 2024
@linear Linear
Copy link

linear bot commented Jul 17, 2024

ENG-364 Implement a file tree serialiser/de-serialiser

@tegefaulkes tegefaulkes mentioned this pull request Jul 21, 2024
Open
@tegefaulkes tegefaulkes force-pushed the feature-eng-364-implement-a-file-tree-serialiserde-serialiser branch from 84d2264 to cfc1c0c Compare July 24, 2024 01:33
@tegefaulkes tegefaulkes force-pushed the feature-eng-364-implement-a-file-tree-serialiserde-serialiser branch from 1cf904d to 262b213 Compare July 25, 2024 03:50
@tegefaulkes tegefaulkes marked this pull request as ready for review July 25, 2024 03:50
@tegefaulkes tegefaulkes requested review from aryanjassal and removed request for aryanjassal July 25, 2024 03:50
@tegefaulkes tegefaulkes merged commit 76b4cf2 into staging Jul 26, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tegefaulkes tegefaulkes

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement a file tree serialiser/de-serialiser
1 participant
@tegefaulkes