-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up superfluous compilation flags #43
Labels
Comments
19 tasks
11 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Specification
The current gyp files specify compilation flags in such a way that it leads to repeated superfluous flags.
Basically I believe flags/options like
-std
,-stdlib
, and-mmacosx-version-min
and-arch
should be configured so there's not so much repetition.This has to do with the way our
binding.gyp
is specifying the compilation options. Thegyp
format has a lot of ways of doing things, and it is likely some options are being "appended", where we should actually override existing options, rather than just appending new options.At the same time, the
node-gyp
sort of combines the gyp files with configuration coming from the default gyp file that is in nodejs itself, and that can be a source of problems.Additional context
Tasks
The text was updated successfully, but these errors were encountered: