Skip to content

Refactoring EFS & Align coding standards with js-polykey #47

Closed
@CMCDragonkai

Description

@CMCDragonkai

Specification

  • The js-encryptedfs is a core library of js-polykey, its coding standards should be aligned with how we are developing things in js-polykey
  • This means the class structure
  • Ensuring that we are properly using async await in most cases, and keeping the callback style of the original methods
  • Testing
  • Linting

Tasks

  1. Make sure all methods in EncryptedFS uses public or protected, no need to use private
  2. Helper methods should probably be moved into a separate utilities function. There are a lot of helper methods.
  3. Provide a promise interface under fs.promises. So you can do efs.promises.f where f is an awaitable version of the functions.

Addressed https://gitlab.com/MatrixAI/Engineering/Polykey/js-encryptedfs/-/merge_requests/46

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions