Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updating cargo.toml and package.json before version commit #29

Merged
merged 4 commits into from
May 24, 2023

Conversation

tegefaulkes
Copy link
Contributor

@tegefaulkes tegefaulkes commented May 23, 2023

Description

This PR adds a version script that updates the cargo.toml version to match the new package.json version when a npm version is run.

It also rolls the postVersion script into the version script. The changes from the postVersion script were not included in the tagged version commit.

Issues Fixed

Tasks

  • 1. Ensure that automatic changes to the version numbers in the package.json dependencies and cargo.toml file are updated with the new version from the npm version command. ensure that these changes are included in the tagged version commit.
  • 2. Ensure that there are no un-staged or un-commited changes that should be included in the commit.
  • 3. Verify this all works with a pre-release version.

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@tegefaulkes tegefaulkes self-assigned this May 23, 2023
@ghost
Copy link

ghost commented May 23, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@tegefaulkes
Copy link
Contributor Author

Do we want to add anything else while we're here? Such as some checks in the preVersion stage? Such as a lint, build and test check?

@tegefaulkes
Copy link
Contributor Author

Ah, the cargo lock file isn't being updated, we want to commit changes to that as well.

@tegefaulkes
Copy link
Contributor Author

That should fix it. Running npm install and npm run build shouldn't result in updates to any lock files. Except for the optional dependencies, these will change based off of platform and availability.

@tegefaulkes
Copy link
Contributor Author

I think the only thing left is to merge and run a test job to see if it publishes.

@CMCDragonkai
Copy link
Member

Is this going to be merged?

@tegefaulkes tegefaulkes merged commit dd13f2c into staging May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Automatically bump cargo.toml version to match package.json.
2 participants