don't fill an element with bogus size

Return early if the size is not valid.
Matroska-Org · Jan 13, 2024 · 837c505 · 837c505
1 parent 947926f
commit 837c505
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/EbmlElement.cpp b/src/EbmlElement.cpp
@@ -219,15 +219,15 @@ EbmlElement * EbmlElement::FindNextID(IOCallback & DataStream, const EbmlCallbac
   if (Result == nullptr)
     return nullptr;
 
-  Result->SetSizeLength(PossibleSizeLength);
-
-  Result->Size = SizeFound;
-
   if (!Result->ValidateSize()) {
     delete Result;
     return nullptr;
   }
 
+  Result->SetSizeLength(PossibleSizeLength);
+
+  Result->Size = SizeFound;
+
   Result->SetSizeInfinite(SizeFound == SizeUnknown);
   Result->ElementPosition = aElementPosition;
   Result->SizePosition = aSizePosition;