Use a vector in MemIOCallback #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the instance is not supposed to be modified, neither are its data.
It allows simple reallocation (resizing). It should be more efficient when adding data little by little.
robUx4
added
api-break
mbunkus
approved these changes
Dec 30, 2023
| @@ -61,7 +63,7 @@ class EBML_DLL_API MemIOCallback : public IOCallback | |||
| */ | |||
| void close() override {} | |||
|
|
|||
| binary *GetDataBuffer() const {return dataBuffer;} | |||
| const binary *GetDataBuffer() const {return dataBuffer.data();} | |||
There was a problem hiding this comment.
I assume that the intention of the GetDataBuffer function is to have direct read-only access to the underlying storage. If write access is also wanted, then you could leave out the const & return &dataBuffer[0] instead.
There was a problem hiding this comment.
We can also use data() for that, we just need to leave the const on both sides of the method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.