Misc. cleanups #204
Merged
Misc. cleanups #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We never export any of these EBML types.
So it uses the same storage name as the other base classes.
Just like other includes in the installed headers.
constexpr doesn't imply const
They have exactly the same defintion and shouldn't differ in the future.
The default constructor doesn't work anymore as it needs the proper EbmlCallbacks It's not used by anyone.
So we only have to change one to make changes on all types.
Even if we don't use it.
robUx4
added
enhancement
abi-break
mbunkus
approved these changes
Jan 1, 2024
|
This PR is fine (both from the "looks good to me" point of view & from the "my test cases are all fine" point of view). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #186 so only the juicy parts remain there. Plus some more macro factorization.