Pass the size to check on an element #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robUx4
added
api-break
mbunkus
approved these changes
Jan 13, 2024
We should not have to force the element to have a size to check if it's valid. It may end up in a state where it's invalid. We keep a ValidateSize() method for compatibility (VLC).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than ValidateSize() which requires to set the value on the element first, we can check if the size is valid before doing it, or rejecting the element in that case.
On top of #212 and #213.It might be possible to get the information from the element specs (and avoid creating an element just to delete right after), but that will be for another Pull Request.