-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Header cleanup #221
Merged
Merged
Header cleanup #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robUx4
force-pushed
the
header_cleanup
branch
from
January 13, 2024 17:41
e33fd66
to
a79c73d
Compare
It's not used by anyone and is not a core functionality of libebml. It can be done externally as the test shows.
People using the header should also know about versioning.
It's always implied
robUx4
force-pushed
the
header_cleanup
branch
from
January 13, 2024 17:48
a79c73d
to
8fdbe45
Compare
mbunkus
approved these changes
Jan 13, 2024
robUx4
added a commit
to robUx4/libebml
that referenced
this pull request
Jan 14, 2024
Merged
robUx4
added a commit
to robUx4/libebml
that referenced
this pull request
Jan 14, 2024
robUx4
added a commit
that referenced
this pull request
Jan 14, 2024
robUx4
added a commit
that referenced
this pull request
Jan 14, 2024
robUx4
added a commit
to robUx4/libmatroska
that referenced
this pull request
Jan 14, 2024
robUx4
added a commit
to Matroska-Org/libmatroska
that referenced
this pull request
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #219