Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass std::function by const ref #231

Merged
merged 3 commits into from
Jan 28, 2024
Merged

pass std::function by const ref #231

merged 3 commits into from
Jan 28, 2024

Commits on Jan 28, 2024

  1. change UpdateSize to pass const ref 

    std::function is not trivially copyable, while means it's more efficient
to pass by const ref.

This change allows clang-tidy to make the necessary modifications
everywhere else.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
    @neheb
    neheb committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    a051979 View commit details
    Browse the repository at this point in the history

  2. clang-tidy: performance fixes 

    Signed-off-by: Rosen Penev <rosenp@gmail.com>
    @neheb
    neheb committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    96b2984 View commit details
    Browse the repository at this point in the history

  3. RenderData: change param to const ref 

    Last one remaining. std::function should not be passed by value.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
    @neheb
    neheb committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    2160568 View commit details
    Browse the repository at this point in the history