Reduce the number of methods and cleanup some macros #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robUx4
added
api-break
hmmmmm |
mbunkus
requested changes
Feb 18, 2024
ebml/EbmlElement.h
Outdated
| @@ -234,32 +234,31 @@ class DllApi x : public BaseClass { \ | |||
|
|
|||
| #define EBML_CONCRETE_CLASS(Type) \ | |||
| public: \ | |||
| libebml::EbmlElement & CreateElement() const override {return Create();} \ | |||
There was a problem hiding this comment.
This doesn't work for me. There are places where I have a generic EbmlElement, and I need to create another instance of the same type. Before I could just use this function; now I cannot see a way to do it anymore.
There was a problem hiding this comment.
Indeed, we need this for generic usage. I dropped this commit.
robUx4
force-pushed
the
direct_create
branch
2 times, most recently
from
01f8416
to
b1f9ac1
Compare
mbunkus
requested changes
Feb 24, 2024
| @@ -427,10 +427,9 @@ EbmlElement *EbmlElement::CreateElementUsingContext(const EbmlId & aID, const Eb | |||
| // elements at the current level | |||
| for (unsigned int ContextIndex = 0; ContextIndex < EBML_CTX_SIZE(Context); ContextIndex++) { | |||
| if (aID == EBML_CTX_IDX_ID(Context,ContextIndex)) { | |||
| auto ClassInfos = EBML_CTX_IDX(Context,ContextIndex); | |||
| if (AsInfiniteSize && !ClassInfos.GetCallbacks().CanHaveInfiniteSize()) | |||
| if (AsInfiniteSize && !EBML_CTX_IDX_INFO(Context,ContextIndex).CanHaveInfiniteSize()) | |||
There was a problem hiding this comment.
When merging this PR to the current master, this line doesn't compile anymore:
lib/libebml/src/EbmlElement.cpp:430:70: fatal error: no member named 'CanHaveInfiniteSize' in 'libebml::EbmlSemantic'
if (AsInfiniteSize && !EBML_CTX_IDX_INFO(Context,ContextIndex).CanHaveInfiniteSize())
There was a problem hiding this comment.
Rebased on top of #267 which has a bit more macro usage and fixes that issue.
We can differentiate between the "pure" access macros and the "wrapper" ones.
EBML_CTX_IDX(MasterContext,EltIdx).GetCallbacks() is equivalent to EBML_CTX_IDX_INFO(MasterContext,EltIdx)
We can just use the semantic. No need to create a function for each existing class.
According to 8613939 it was kept for compatibility, but we're breaking the API.
Just like every other Ebml element that will have a Create().
But not static as some may be exported.
robUx4
force-pushed
the
direct_create
branch
from
b1f9ac1
to
dde8107
Compare
mbunkus
approved these changes
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can do with less methods and reuse the methods that already exist to do the same calls.
That will make things easier to maintain.