restrict the ranges of valid EBML ID values #298
+9
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default value is not handled in all classes that can have one
See IANA validation rules https://www.rfc-editor.org/rfc/rfc8794.html#section-17.1
The DEFINE_EBML_CLASS_ORPHAN() validates the ID but we can do without. En EbmlDummy instance cannot be created without an actual ID.
Match the exact values allowed in RFC 8794 Table 4 and 17.1 Ebml ID registry with errata https://www.rfc-editor.org/rfc/rfc8794.html#tableElementIDRanges https://www.rfc-editor.org/rfc/rfc8794.html#name-ebml-element-ids-registry Not allowing the reserved values 0xFF, 0x7FFF, 0x3FFFFF and 0x1FFFFFFF.
robUx4
force-pushed
the
tighter-ebmlids
branch
from
7c9e52b
to
c281659
Compare
robUx4
referenced
this pull request
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Match the exact values allowed in RFC 8794 Table 4 and 17.1 Ebml ID registry with errata https://www.rfc-editor.org/rfc/rfc8794.html#tableElementIDRanges https://www.rfc-editor.org/rfc/rfc8794.html#name-ebml-element-ids-registry
Not allowing the reserved values 0xFF, 0x7FFF, 0x3FFFFF and 0x1FFFFFFF. As they are reserved value maybe we should allow them in case they are used in the future ? But we don't know how.
EbmlDummyuses 0xFF internally which is supposed to be reserved. That ID value is never used but it's still an EbmlId object with a reserved/invalid value.From the issue raised in 5326cfe#commitcomment-147015759